Remove editable annotations #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 24, 2025 13:50
- Remove more spurious normalizers
- Remove 2 extra editable annotations
Pull Request Test Coverage Report for Build 12952648342Details
💛 - Coveralls |
|
@JFRudzinski let me know if I should invite somebody else to review |
JFRudzinski
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Looks good, thank you @ndaelman-hu !
I guess the normalize function with super().normalize is a part of the parent classes through inheritance, so they are automatically included, is that right?
Indeed, that's standard behaviour in OOP, and NOMAD does not modify this. Unless you overwrite it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from removing editable quantities, this PR also removes redundant normalizers
closes #161