-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setup to respect other plugins #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can work on improving this README part on the local installation setup. It is just not the moment now.
Please, leave this as a PR for now, we can work it out next week or in a couple of weeks.
|
||
```yaml | ||
plugins: | ||
include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, we can leave this here. It is just about probably adding the comment that you can find in the nomad.yaml if you feel so.
Furthermore, it seems that manually installing nomad-lab[parsing] fixes the built-in plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is the only correction, so no need to further work on it: I haven't seen any other errors, and have verified that this here works...
You can ask Lauri to take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this comment now:
Please, we can leave this here. It is just about probably adding the comment that you can find in the nomad.yaml if you feel so
No, this setup disables ALL other plugins, which should never be the default! There are only a few scenarios where this is wishful. You only need options
to add plugins to the list, then you can run all of them.
I do think that this has not been properly explained in the general docs. I'll see to amend that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double-check, @JFRudzinski or @Bernadette-Mohr, following the old setup, can you still run the regular parsers?
Not the tests, but the actual parsers.
I am curious about which exact problems you are having now. We should simply change the text pointing to the diffs between having a local installation and a NOMAD oasis, and I agree this is in the general docu. Here we just fix the text. Did you also check the general documentation page? More specifically, this one: https://nomad-lab.eu/prod/v1/staging/docs/howto/oasis/plugins_install.html#add-a-plugin-to-nomad |
The issue is that the README instructions give undesired results, i.e. I can no longer utilize the other plugins, such as parsers, after applying these steps. |
Given that the setup has changed, and now it works without conflict, I am closing this PR. |
Clarify use of
include
andexclude
in the setup instructions.Should we maybe just refer to the general docs for the setup?