[WIP, ON HOLD] Add opacity aesthetic #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+1056
to
+1060
| class Opacity extends StatefulAesthetic<Opacity> { | ||
| get Factory() { | ||
| return Opacity; | ||
| } | ||
| } |
There was a problem hiding this comment.
There's a naming conflict between the two Opacity class definitions. To maintain consistency with the codebase's naming pattern (as seen with StatefulSize, StatefulY, etc.), this class should be renamed to StatefulOpacity.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it just has some notes Ben & I jotted down going through the codebase. This is not valid code right now
Eventually, this'll add the opacity aesthetic.