Multi building checkpoints #716

error: the variable `removed_deposits` is used as a loop counter --> src/bitcoin/mod.rs:1082:9 | 1082 | for dest in keys { | ^^^^^^^^^^^^^^^^ help: consider using: `for (removed_deposits, dest) in keys.into_iter().enumerate()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop = note: `-D clippy::explicit-counter-loop` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::explicit_counter_loop)]`

this expression creates a reference which is immediately dereferenced by the compiler: src/bitcoin/checkpoint.rs#L2530

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/bitcoin/checkpoint.rs:2530:55 | 2530 | adjust_fee_rate(prev_fee_rate, false, &config) | ^^^^^^^ help: change this to: `config` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/bitcoin/checkpoint.rs#L2523

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/bitcoin/checkpoint.rs:2523:54 | 2523 | adjust_fee_rate(prev_fee_rate, true, &config) | ^^^^^^^ help: change this to: `config` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

question mark operator is useless here: src/bitcoin/checkpoint.rs#L1986

error: question mark operator is useless here --> src/bitcoin/checkpoint.rs:1986:9 | 1986 | Ok(self.get_mut(index)?) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `self.get_mut(index)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `-D clippy::needless-question-mark` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_question_mark)]`

unneeded `return` statement: src/bitcoin/checkpoint.rs#L1879

error: unneeded `return` statement --> src/bitcoin/checkpoint.rs:1879:25 | 1879 | Err(err) => return Err(err), | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 1879 | Err(err) => Err(err), | ~~~~~~~~

this function has too many arguments (8/7): src/bitcoin/checkpoint.rs#L1623

error: this function has too many arguments (8/7) --> src/bitcoin/checkpoint.rs:1623:5 | 1623 | / pub fn advance( 1624 | | mut self, 1625 | | nbtc_accounts: &Accounts<Nbtc>, 1626 | | recovery_scripts: &Map<orga::coins::Address, Adapter<bitcoin::Script>>, ... | 1631 | | first: bool, 1632 | | ) -> Result<BuildingAdvanceRes> { | |___________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `-D clippy::too-many-arguments` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`

variable `removed_deposits` is assigned to, but never used: src/bitcoin/mod.rs#L1075

error: variable `removed_deposits` is assigned to, but never used --> src/bitcoin/mod.rs:1075:17 | 1075 | let mut removed_deposits = 0; | ^^^^^^^^^^^^^^^^ | = note: consider using `_removed_deposits` instead = note: `-D unused-variables` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_variables)]`

this `else { if .. }` block can be collapsed: src/bitcoin/checkpoint.rs#L2527

error: this `else { if .. }` block can be collapsed --> src/bitcoin/checkpoint.rs:2527:16 | 2527 | } else { | ________________^ 2528 | | if self.has_completed_checkpoint()? { 2529 | | // No unconfirmed checkpoints. 2530 | | adjust_fee_rate(prev_fee_rate, false, &config) ... | 2535 | | } 2536 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `-D clippy::collapsible-else-if` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::collapsible_else_if)]` help: collapse nested if block | 2527 ~ } else if self.has_completed_checkpoint()? { 2528 + // No unconfirmed checkpoints. 2529 + adjust_fee_rate(prev_fee_rate, false, &config) 2530 + } else { 2531 + // This case only happens at start of chain - having no 2532 + // unconfs doesn't mean anything. 2533 + prev_fee_rate 2534 ~ }; |

unused import: `map::ReadOnly`: src/bitcoin/checkpoint.rs#L25

error: unused import: `map::ReadOnly` --> src/bitcoin/checkpoint.rs:25:19 | 25 | collections::{map::ReadOnly, ChildMut, Deque, Map, Ref}, | ^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]`

clippy

Clippy had exited with the 101 exit code

format

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

format

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

format

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

format

build-wasm

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

build-wasm

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build-wasm

clippy

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

clippy

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

clippy

check-rest

test-base

test-all-features

test-bitcoin

coverage

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, codecov/codecov-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

coverage

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

coverage

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi building checkpoints #716

Summary

Multi building checkpoints #716

Jobs

Run details

ci.yml

Annotations