Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying RPC address via --node in CLI commands #188

Merged
merged 7 commits into from
Aug 31, 2023

Conversation

mappum
Copy link
Contributor

@mappum mappum commented Aug 31, 2023

Support --node in CLI commands, defaulting to localhost:26657. A future change should also make the default check the Tendermint config to support nonstandard ports automatically.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #188 (feb3b6f) into develop (7a74a31) will decrease coverage by 0.16%.
The diff coverage is 2.35%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
- Coverage    14.80%   14.64%   -0.16%     
===========================================
  Files           22       22              
  Lines         6135     6206      +71     
===========================================
+ Hits           908      909       +1     
- Misses        5227     5297      +70     
Files Changed Coverage Δ
src/bin/nomic.rs 0.00% <0.00%> (ø)
src/bitcoin/checkpoint.rs 9.51% <ø> (ø)
src/lib.rs 0.00% <0.00%> (ø)
src/network.rs 0.00% <0.00%> (ø)
src/utils.rs 0.00% <0.00%> (ø)
src/bitcoin/relayer.rs 12.63% <14.28%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mappum mappum merged commit 931d7a0 into develop Aug 31, 2023
@mappum mappum deleted the node-cli-option branch August 31, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants