Limit scan depth for unconfirmed checkpoints #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mappum
force-pushed
the
relayer-checkpoint-conf-fix
branch
from
ef87add to
958d3d3
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #218 +/- ##
===========================================
- Coverage 29.53% 29.51% -0.02%
===========================================
Files 23 23
Lines 7394 7399 +5
===========================================
Hits 2184 2184
- Misses 5210 5215 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mappum
force-pushed
the
relayer-checkpoint-conf-fix
branch
from
958d3d3 to
12778e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relayer was not submitting proofs of checkpoint confirmation since it was searching from the oldest unconfirmed, but only looking back 100 blocks. We don't want to always use the newest unconfirmed since it is a moving target and on an active network there is likely always a tip which is unconfirmed - as a middle ground we use the oldest unconfirmed at a maximum of 5 checkpoints behind the tip (this will need parameterizing in the future).