Add max_unconfirmed_checkpoints parameter #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mappum
force-pushed
the
limit-unconfirmed-checkpoints
branch
from
e71402b to
a989d7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the network from having runaway checkpoints if they are for some reason not being confirmed on Bitcoin (for example, there was a standardness or validity issue, fees were too low, relayers are having issues relaying the confirmations which is incorrectly driving up the fee rate, the Bitcoin network is having issues, etc.). We now properly reflect the issues by not processing transfers until the checkpoints can be confirmed.