Forward ROCKSDB envvars through to build script legacy build #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #246 +/- ##
========================================
Coverage 33.56% 33.56%
========================================
Files 24 24
Lines 8213 8213
========================================
Hits 2757 2757
Misses 5456 5456 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mappum
force-pushed
the
build-script-rocksdb
branch
from
a119067 to
9aed74f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should slightly reduce legacy bin build times in the build script when a system RocksDB lib is specified through the
ROCKSDB_LIB_DIRenvironment variable.