Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to generate deposit addresses within a buffer time for expired sigsets #269

Merged
merged 10 commits into from
Feb 6, 2024

Conversation

cwlittle
Copy link
Contributor

@cwlittle cwlittle commented Feb 2, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (d0b427f) 33.36% compared to head (7c6900d) 33.32%.
Report is 5 commits behind head on develop.

Files Patch % Lines
src/bitcoin/checkpoint.rs 33.33% 26 Missing ⚠️
src/bitcoin/relayer.rs 0.00% 15 Missing ⚠️
src/bitcoin/signatory.rs 41.17% 10 Missing ⚠️
src/bitcoin/mod.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #269      +/-   ##
===========================================
- Coverage    33.36%   33.32%   -0.05%     
===========================================
  Files           24       24              
  Lines         8260     8307      +47     
===========================================
+ Hits          2756     2768      +12     
- Misses        5504     5539      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mappum mappum merged commit 7f41811 into develop Feb 6, 2024
9 checks passed
@mappum mappum deleted the fail-on-expired-sigset branch February 6, 2024 23:25
@mappum mappum restored the fail-on-expired-sigset branch February 7, 2024 00:23
mappum added a commit that referenced this pull request Feb 7, 2024
mappum added a commit that referenced this pull request Feb 7, 2024
Revert "Merge pull request #269 from nomic-io/fail-on-expired-sigset"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants