Checkpoint backfill #272
Merged
Checkpoint backfill #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mappum
force-pushed
the
checkpoint-backfill
branch
from
47eb997 to
d46a6ff
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #272 +/- ##
===========================================
+ Coverage 34.41% 37.39% +2.97%
===========================================
Files 25 26 +1
Lines 8809 9317 +508
===========================================
+ Hits 3032 3484 +452
- Misses 5777 5833 +56 ☔ View full report in Codecov by Sentry. |
mappum
force-pushed
the
checkpoint-backfill
branch
2 times, most recently
from
f7c2298 to
7563ac3
Compare
mappum
force-pushed
the
checkpoint-backfill
branch
from
7563ac3 to
f7c2298
Compare
mappum
force-pushed
the
checkpoint-backfill
branch
from
f7c2298 to
93f44ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to
CheckpointQueuewhich takes in an iterator of previous reserve redeem scripts, reconstructs the past signatory sets (with a possible loss of precision in voting power, which is OK because the same script will still be derived from it), then uses these signatory sets to insert past checkpoints into the queue.Additionally, a binary is added to retrieve past reserve redeem scripts from the Bitcoin blockchain.
This change will allow for the recovery mechanism in #258 to be used even for deposits to signatory sets which have been pruned - the checkpoints/sigsets can now be repopulated in a migration during a network upgrade.