-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail to generate deposit addresses for soon to expire sigsets #274
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #274 +/- ##
===========================================
- Coverage 37.39% 37.32% -0.07%
===========================================
Files 26 26
Lines 9317 9329 +12
===========================================
- Hits 3484 3482 -2
- Misses 5833 5847 +14 ☔ View full report in Codecov by Sentry. |
src/bitcoin/mod.rs
Outdated
pub fee_pool_reward_split: (u64, u64), | ||
|
||
#[orga(version(V5))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since V4 was added after the last stakenet upgrade, we don't have to add a V5. This field can just be added to V4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also though - it does seem surprising that a relayer change involves a change to on-chain state, since this buffer doesn't affect consensus. Could we avoid that by using a constant (e.g. the buffer period is 10% of max_deposit_age
)?
No description provided.