Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to generate deposit addresses for soon to expire sigsets #274

Merged
merged 9 commits into from
Feb 12, 2024

Conversation

cwlittle
Copy link
Contributor

@cwlittle cwlittle commented Feb 7, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (49f959a) 37.39% compared to head (bb45de7) 37.32%.
Report is 5 commits behind head on develop.

Files Patch % Lines
src/bitcoin/relayer.rs 3.57% 27 Missing ⚠️
src/bitcoin/mod.rs 0.00% 2 Missing ⚠️
src/bin/nomic.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
- Coverage    37.39%   37.32%   -0.07%     
===========================================
  Files           26       26              
  Lines         9317     9329      +12     
===========================================
- Hits          3484     3482       -2     
- Misses        5833     5847      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pub fee_pool_reward_split: (u64, u64),

#[orga(version(V5))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since V4 was added after the last stakenet upgrade, we don't have to add a V5. This field can just be added to V4.

Copy link
Contributor

@mappum mappum Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also though - it does seem surprising that a relayer change involves a change to on-chain state, since this buffer doesn't affect consensus. Could we avoid that by using a constant (e.g. the buffer period is 10% of max_deposit_age)?

@mappum mappum enabled auto-merge February 12, 2024 21:34
@mappum mappum merged commit 5bbc01a into develop Feb 12, 2024
9 checks passed
@mappum mappum deleted the fail-on-expired-sigset branch February 12, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants