Ensure resulting threshold integer matches script in SignatorySet::from_script
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #278 +/- ##
===========================================
+ Coverage 37.39% 37.48% +0.09%
===========================================
Files 26 26
Lines 9318 9339 +21
===========================================
+ Hits 3484 3501 +17
- Misses 5834 5838 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deriving a
SignatorySetfrom a redeem script, the resulting threshold value may be calculated differently when derived from truncated voting power vs non-truncated voting power. To ensure the threshold is the same regardless, this PR compares to the expected threshold in the redeem script passed in, and adjusts thepresent_vpfield accordingly.