Testnet 7.1 staging #658
clippy
9 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 9 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.71.0-nightly (c4190f2d3 2023-05-07)
- cargo 1.71.0-nightly (569b648b5 2023-05-05)
- clippy 0.1.71 (c4190f2 2023-05-07)
Annotations
Check failure on line 202 in src/cosmos.rs
github-actions / clippy
useless conversion to the same type: `bitcoin::threshold_sig::Pubkey`
error: useless conversion to the same type: `bitcoin::threshold_sig::Pubkey`
--> src/cosmos.rs:196:22
|
196 | let op_key = Pubkey::try_from_slice(
| ______________________^
197 | | proto::cosmos::crypto::secp256k1::PubKey::from_any(&op_key_any)
198 | | .map_err(|_| OrgaError::App("Invalid public key".to_string()))?
199 | | .key
200 | | .as_slice(),
201 | | )?
202 | | .into();
| |_______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing `.into()`
|
196 ~ let op_key = Pubkey::try_from_slice(
197 + proto::cosmos::crypto::secp256k1::PubKey::from_any(&op_key_any)
198 + .map_err(|_| OrgaError::App("Invalid public key".to_string()))?
199 + .key
200 + .as_slice(),
201 ~ )?;
|
Check failure on line 175 in src/bitcoin/threshold_sig.rs
github-actions / clippy
useless conversion to the same type: `bitcoin::threshold_sig::Pubkey`
error: useless conversion to the same type: `bitcoin::threshold_sig::Pubkey`
--> src/bitcoin/threshold_sig.rs:175:17
|
175 | signatory.pubkey.into(),
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `signatory.pubkey`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check failure on line 253 in src/bitcoin/signatory.rs
github-actions / clippy
useless conversion to the same type: `bitcoin::threshold_sig::Pubkey`
error: useless conversion to the same type: `bitcoin::threshold_sig::Pubkey`
--> src/bitcoin/signatory.rs:253:25
|
253 | pubkey: pubkey.into(),
| ^^^^^^^^^^^^^ help: consider removing `.into()`: `pubkey`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check failure on line 238 in src/bitcoin/signatory.rs
github-actions / clippy
useless conversion to the same type: `bitcoin::threshold_sig::Pubkey`
error: useless conversion to the same type: `bitcoin::threshold_sig::Pubkey`
--> src/bitcoin/signatory.rs:238:25
|
238 | pubkey: pubkey.into(),
| ^^^^^^^^^^^^^ help: consider removing `.into()`: `pubkey`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
Check failure on line 442 in src/app.rs
github-actions / clippy
`.map().collect()` can be replaced with `.try_for_each()`
error: `.map().collect()` can be replaced with `.try_for_each()`
--> src/app.rs:436:17
|
436 | / include_str!("../testnet_addresses.csv")
437 | | .lines()
438 | | .map(|line| {
439 | | let address = line.parse().unwrap();
440 | | self.accounts.deposit(address, Coin::mint(10_000_000_000))
441 | | })
442 | | .collect::<Result<()>>()?;
| |____________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_collect_result_unit
= note: `-D clippy::map-collect-result-unit` implied by `-D warnings`
help: try this
|
436 ~ include_str!("../testnet_addresses.csv")
437 + .lines().try_for_each(|line| {
438 + let address = line.parse().unwrap();
439 + self.accounts.deposit(address, Coin::mint(10_000_000_000))
440 ~ })?;
|
Check failure on line 346 in src/bitcoin/threshold_sig.rs
github-actions / clippy
unused import: `std::io::Read`
error: unused import: `std::io::Read`
--> src/bitcoin/threshold_sig.rs:346:5
|
346 | use std::io::Read;
| ^^^^^^^^^^^^^
Check failure on line 16 in src/bitcoin/threshold_sig.rs
github-actions / clippy
unused import: `orga::store::Store`
error: unused import: `orga::store::Store`
--> src/bitcoin/threshold_sig.rs:16:5
|
16 | use orga::store::Store;
| ^^^^^^^^^^^^^^^^^^
Check failure on line 14 in src/bitcoin/threshold_sig.rs
github-actions / clippy
unused import: `orga::query::FieldQuery`
error: unused import: `orga::query::FieldQuery`
--> src/bitcoin/threshold_sig.rs:14:5
|
14 | use orga::query::FieldQuery;
| ^^^^^^^^^^^^^^^^^^^^^^^
Check failure on line 13 in src/bitcoin/threshold_sig.rs
github-actions / clippy
unused import: `orga::prelude::FieldCall`
error: unused import: `orga::prelude::FieldCall`
--> src/bitcoin/threshold_sig.rs:13:5
|
13 | use orga::prelude::FieldCall;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`