persistent logger (for bucket notifications) - don't log rename ENOENT if there were no failures #8765
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphaprinz
changed the title
tangledbytes
reviewed
Feb 6, 2025
| @@ -198,7 +198,7 @@ class PersistentLogger { | |||
|
|
|||
| try { | |||
| // Finally replace the current active so as to consume them in the next iteration | |||
| await failure_log._replace_active(); | |||
| await failure_log._replace_active(!result); | |||
There was a problem hiding this comment.
We should log ENOENT if the last processed journal (aka log) in a journal namespace was not deleted?
There was a problem hiding this comment.
Yes, the not-delete file needs to be replaced. (That's what I understand, correct me if I'm wrong. In my use case I always delete the the processed files.)
…T if there were no failures Signed-off-by: Amit Prinz Setter <[email protected]>
alphaprinz
force-pushed
the
notif_rename
branch
from
15729d4 to
5b75f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR changes the rename to not log ENOENT in case there were no failures.
Let me know if you have other ideas.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: