Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | add configuration flag to enable dynamic supplemental groups allocation #8769

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Feb 5, 2025

Explain the changes

  1. add environment variable to enable/disable dynamic supplemental groups allocation
  2. in case this value is set in the configuration file. the configuration file value will override the default value
  3. change os_linux, os_darwing to get supplemental groups dinamicly only when this flag is not false

Issues:

GAP

implement and test on containerized environment: dynamic supplemental groups should work. need to test environment variable passes correctly to fs_worker

Testing Instructions:

  1. automatic tests: sudo node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nsfs_access.js
  2. manual tests:
    a. add new user with uid that matches an fs user with supplemental groups
    b. add new user that his GID matches a group user 1 is a part of
    c. create new bucket by user 2
    d. add "NSFS_ENABLE_DINAMIC_SUPPLEMENTAL_GROUPS" : false to config.json
    e. put object using user 1
    f. operation should fail. should get permission denied
  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz self-assigned this Feb 5, 2025
config.js Outdated Show resolved Hide resolved
src/native/util/os_darwin.cpp Outdated Show resolved Hide resolved
config.js Show resolved Hide resolved
@nadavMiz nadavMiz force-pushed the suplemental_groups_configuration branch from c44db7a to bbdce3c Compare February 5, 2025 11:10
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 5, 2025
@nadavMiz nadavMiz force-pushed the suplemental_groups_configuration branch 3 times, most recently from 4306b4b to 58335cf Compare February 5, 2025 12:49
@nadavMiz nadavMiz requested a review from romayalon February 5, 2025 14:36
@nadavMiz nadavMiz changed the title NSFS | add configuration flag to enable dinamic supplemental groups allocation NSFS | add configuration flag to enable dynamic supplemental groups allocation Feb 6, 2025
config.js Outdated Show resolved Hide resolved
config.js Outdated Show resolved Hide resolved
config.js Show resolved Hide resolved
config.js Outdated Show resolved Hide resolved
@nadavMiz nadavMiz force-pushed the suplemental_groups_configuration branch from 58335cf to 0ff7ed8 Compare February 9, 2025 16:18
@nadavMiz nadavMiz force-pushed the suplemental_groups_configuration branch from 0ff7ed8 to 58ad973 Compare February 10, 2025 19:10
@nadavMiz nadavMiz merged commit ad6b361 into noobaa:master Feb 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants