Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http://{endpoint_address}:{s3_port}/_/version api to the endpoint #8786

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Feb 12, 2025

Explain the changes

  1. Create an API for receiving the package version of NooBaa via the endpoint.

Issues: Fixed #xxx / Gap #xxx

  1. Gap - add a CLI call for that?
  2. move other internal apis to be under /_/

Testing Instructions:

Happy path manual Test -

  1. Tab 1 - sudo node noobaa-core/src/cmd/nsfs.js --debug 5
  2. Tab 2 - call the new /_/version api -
> curl http://localhost:6001/_/version
5.19.0%

Bad path manual test -

  1. Tab 1 - sudo node noobaa-core/src/cmd/nsfs.js --debug 5
  2. Tab 2 - call the new /_/version1 api -
> curl http://localhost:6001/_/version1
{"error":"Internal Server Error","message":"Unknown API call version1"}%
  • Doc added/updated
  • Tests added

src/endpoint/endpoint.js Outdated Show resolved Hide resolved
src/endpoint/endpoint.js Outdated Show resolved Hide resolved
src/endpoint/endpoint.js Outdated Show resolved Hide resolved
src/endpoint/endpoint.js Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 13, 2025
@romayalon romayalon changed the title Add http://{endpoint_address}:{s3_port}/_version api to the endpoint Add http://{endpoint_address}:{s3_port}/_/version api to the endpoint Feb 13, 2025
@romayalon romayalon requested a review from guymguym February 13, 2025 09:24
@romayalon romayalon force-pushed the romy-add-version-endpoint-api branch from cf74865 to 1a4e210 Compare February 13, 2025 10:05
@romayalon romayalon force-pushed the romy-add-version-endpoint-api branch from 1a4e210 to d9c4c7a Compare February 13, 2025 13:40
@romayalon romayalon merged commit aef9956 into noobaa:master Feb 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants