-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkin for extending javascript types #182
base: master
Are you sure you want to change the base?
Conversation
i would add a test in noosParser.test.js to verify extend property set. @markbjerke, Could you apply here Doug's review changes #165 ? |
It’s great to see that that memory leak and several other long-standing bugs have been fixed. Thank you @DevSide and @markbjerke! |
Hi @VikramShityalkar and thanks for your support ! You are right, the new tag was not published on NPM, i gonna ask for getting the rights. |
Thanks for your quick response. Getting the latest bits published to NPM would be pretty important for developers like me. I agree with your comments, and I would much prefer to stay with Nools, but I had some concerns about its future when I saw that the project was no longer maintained. Having your involvement and commitment is a huge relief – thank you again! Nools is amazing, and is my preferred rules/inference engine, and it’s great to see the initiative come alive again. I will try to contribute whenever I can, and definitely add bugs and also add 👍to the features that I need. I think the main issue here is not that people don’t want to contribute, but Nools has gone stale as there has been no active involvement by Doug Martin for a while, and the initiative was leaderless. So perhaps it would help if you could post in the Nools Google Group https://groups.google.com/forum/#!forum/nools and let them know about your involvement and that you are starting to fix things, and ask for more active Community contribution. Thank you again! |
@DevSide send me your NPM handle so I can get you added to the package so you can publish. |
Yep => https://www.npmjs.com/~devside |
@VikramShityalkar nools on NPM is up to date now |
I worked hardly to rewrite the code to TypeScript nools-ts and splite the compile and runtime. I could use it in my projects using JSON format now. the JSON file will larger and it will run much more faster. |
Hi Doug, starting over on the pull requests with a cleaner history and a more factored aproach.