Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkin for extending javascript types #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markbjerke
Copy link

Hi Doug, starting over on the pull requests with a cleaner history and a more factored aproach.

@DevSide
Copy link
Collaborator

DevSide commented Oct 1, 2016

i would add a test in noosParser.test.js to verify extend property set. @markbjerke, Could you apply here Doug's review changes #165 ?

@DevSide DevSide added this to the v0.4.3 milestone Oct 5, 2016
@DevSide DevSide modified the milestones: v0.5.0, v0.4.3 Oct 11, 2016
@VikramShityalkar
Copy link

It’s great to see that that memory leak and several other long-standing bugs have been fixed. Thank you @DevSide and @markbjerke!
I have used Nools for a few recent projects, but I was considering switching to node-rules or another rules engine due to the fact that C2FO has announced they are no longer maintaining this project, and there is also a deprecation warning. However, I would strongly prefer to stay with Nools, as I already have experience with it. Do you know if there is an effort by someone in the Nools community to take over maintenance of the code, and will the current fixes be published to NPM? I am happy to contribute where I can, but I lack the deep knowledge and experience about RETE and Drools to be able to take over maintenance of the code. I was also considering posting in the Nools Google Group, but that seems to have gone stale. Thanks!

@DevSide
Copy link
Collaborator

DevSide commented Oct 26, 2016

Hi @VikramShityalkar and thanks for your support ! You are right, the new tag was not published on NPM, i gonna ask for getting the rights.
As i said in another thread, nools and node-rules are fundamentally different. Nools uses a "statefull" session to benefit from the inference, ie it allows iterative changes over time and get rules to be re-evaluated with them.
I'm quite committed now to maintain the project but i won't take off the warning until new other active contributors show up. Main bugs will be fix and some cool features will come.
As a Nools user, you can at least contribute to it in the "issues" section; add some bugs or add 👍 to the features you need.

@VikramShityalkar
Copy link

Thanks for your quick response. Getting the latest bits published to NPM would be pretty important for developers like me.

I agree with your comments, and I would much prefer to stay with Nools, but I had some concerns about its future when I saw that the project was no longer maintained. Having your involvement and commitment is a huge relief – thank you again! Nools is amazing, and is my preferred rules/inference engine, and it’s great to see the initiative come alive again.

I will try to contribute whenever I can, and definitely add bugs and also add 👍to the features that I need. I think the main issue here is not that people don’t want to contribute, but Nools has gone stale as there has been no active involvement by Doug Martin for a while, and the initiative was leaderless. So perhaps it would help if you could post in the Nools Google Group https://groups.google.com/forum/#!forum/nools and let them know about your involvement and that you are starting to fix things, and ask for more active Community contribution.

Thank you again!

@doug-martin
Copy link
Contributor

@DevSide send me your NPM handle so I can get you added to the package so you can publish.

@DevSide
Copy link
Collaborator

DevSide commented Oct 27, 2016

Yep => https://www.npmjs.com/~devside
Thanks @doug-martin

@DevSide
Copy link
Collaborator

DevSide commented Nov 6, 2016

@VikramShityalkar nools on NPM is up to date now

@DevSide DevSide removed this from the v0.5.0 milestone Nov 6, 2016
@taoqf
Copy link

taoqf commented Jun 7, 2017

I worked hardly to rewrite the code to TypeScript nools-ts and splite the compile and runtime. I could use it in my projects using JSON format now. the JSON file will larger and it will run much more faster.
I don't know how to merge nools and nools-ts but I do really want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants