Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MiniProfiler 3.2.0.157 #4

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Conversation

ErikDeRoos
Copy link
Contributor

The underlaying MiniProfiler has been updated to version 3.2.0.157.
Use of the Sql tracing has changed dramatically, so the code is changed to reflect those changes and pose an alternative.

The underlaying MiniProfiler updated to version 3.2.0.157.
Use of the Sql tracing has changed dramatically so the code is changed
to reflect those changes and pose an alternative.
@ErikDeRoos
Copy link
Contributor Author

Hey nootn, i updated the MiniProfiler.Windows code for use in one of my own projects. And i noticed others are waiting for an update also, see #3.

So, here is my update.

I took the liberty of also changing the way the sql tracing works to be compatible with the latest version.
It was a choice i was forced to made: remove all the sql integration, or to try finding a new way of getting database tracing to work.
It became the second option.

There is a note to this code change of mine: because of how your code works (static references) it doesn't work well with multiple sessions. It is a bit confusing because the code might suggest otherwise.

@nootn
Copy link
Owner

nootn commented Sep 11, 2016

OK thanks heaps, I will try and take a look at this in the coming days.

@nootn nootn merged commit 4593000 into nootn:master Sep 26, 2016
@ErikDeRoos
Copy link
Contributor Author

Thank you!
I'll be using this branch in my projects from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants