Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable button for visibility of collaborator's cursor in presentation mode with enabled editing #227

Conversation

ahmadkadri
Copy link
Contributor

@ahmadkadri ahmadkadri commented Nov 9, 2023

… mode with enabled editing

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Bildschirmfoto 2023-11-22 um 12 44 46

image

Bildschirmfoto 2023-11-22 um 12 48 18

@ahmadkadri ahmadkadri requested a review from a team November 9, 2023 11:56
Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: 78b10f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nordeck/matrix-neoboard-widget Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nurjinjafar nurjinjafar force-pushed the nic/feat/PB-3653-Enable-button-for-visibility-of-collaborator's-cursor-in-presentation-mode-with-enabled-editing branch 2 times, most recently from 39fbce2 to 8358673 Compare November 16, 2023 11:40
@nurjinjafar nurjinjafar force-pushed the nic/feat/PB-3653-Enable-button-for-visibility-of-collaborator's-cursor-in-presentation-mode-with-enabled-editing branch from 54a239d to 2d9f609 Compare November 22, 2023 09:41
@nurjinjafar nurjinjafar marked this pull request as draft November 22, 2023 10:18
@nurjinjafar nurjinjafar marked this pull request as ready for review November 22, 2023 12:03
Copy link
Contributor

@maheichyk maheichyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find my review, I would suggest to apply some changes.

nurjinjafar and others added 3 commits November 23, 2023 11:02
Co-authored-by: maheichyk <[email protected]>
Signed-off-by: nurjin jafar <[email protected]>
…y-of-collaborator's-cursor-in-presentation-mode-with-enabled-editing
nurjinjafar and others added 3 commits November 27, 2023 09:37
Signed-off-by: nurjinn jafar <[email protected]>
Signed-off-by: nurjinn jafar <[email protected]>
@nurjinjafar nurjinjafar merged commit 6dfd39d into main Nov 27, 2023
4 checks passed
@nurjinjafar nurjinjafar deleted the nic/feat/PB-3653-Enable-button-for-visibility-of-collaborator's-cursor-in-presentation-mode-with-enabled-editing branch November 27, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants