Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select multiple elements #287

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Select multiple elements #287

merged 5 commits into from
Jan 17, 2024

Conversation

maheichyk
Copy link
Contributor

@maheichyk maheichyk commented Jan 15, 2024

This PR implements selection of multiple elements. Several elements could be selected/unselected using Shift key.

This feature is hidden by REACT_APP_MULTISELECT flag until further operations to move, duplicate, etc on multiple elements are implemented.

Screenshot 2024-01-15 at 15 11 05

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Copy link

changeset-bot bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 8a53133

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nordeck/matrix-neoboard-widget Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maheichyk maheichyk force-pushed the nic/feat/PB-3293_multiselect branch from 25776d0 to d173a7a Compare January 15, 2024 11:58
@maheichyk maheichyk closed this Jan 15, 2024
@maheichyk maheichyk force-pushed the nic/feat/PB-3293_multiselect branch from d173a7a to 2521106 Compare January 15, 2024 12:03
@maheichyk maheichyk reopened this Jan 15, 2024
@maheichyk maheichyk force-pushed the nic/feat/PB-3293_multiselect branch 2 times, most recently from 49700f1 to f27333a Compare January 16, 2024 06:33
Signed-off-by: Mikhail Aheichyk <[email protected]>
@maheichyk maheichyk force-pushed the nic/feat/PB-3293_multiselect branch from c1a1af0 to 3dbf21a Compare January 16, 2024 07:09
@maheichyk maheichyk changed the title Add multiselect initial implementation Select multiple elements Jan 16, 2024
@maheichyk maheichyk marked this pull request as ready for review January 16, 2024 07:18
@maheichyk maheichyk requested a review from a team January 16, 2024 07:18
ahmadkadri
ahmadkadri previously approved these changes Jan 16, 2024
Copy link
Contributor

@ahmadkadri ahmadkadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment it is look good to go

Signed-off-by: Mikhail Aheichyk <[email protected]>
Copy link
Contributor

@mgcm mgcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - copyright year needs adjusting

Signed-off-by: Mikhail Aheichyk <[email protected]>
@maheichyk maheichyk requested a review from mgcm January 17, 2024 07:12
@maheichyk maheichyk merged commit 79bf1b0 into main Jan 17, 2024
4 checks passed
@maheichyk maheichyk deleted the nic/feat/PB-3293_multiselect branch January 17, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants