Send snapshot on join/invite #631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgcm
force-pushed
the
nic/feat/NEO-925-snapshot-on-invite-or-join
branch
from
ab90a22 to
68bc427
Compare
🦋 Changeset detectedLatest commit: 8d6628d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mgcm
force-pushed
the
nic/feat/NEO-925-snapshot-on-invite-or-join
branch
3 times, most recently
from
5168458 to
1f6e508
Compare
mgcm
force-pushed
the
nic/feat/NEO-925-snapshot-on-invite-or-join
branch
2 times, most recently
from
68fc068 to
99b93dc
Compare
weeman1337
requested changes
Nov 14, 2024
packages/react-sdk/src/components/FallbackSnapshotProvider/FallbackSnapshotProvider.tsx
Outdated
Show resolved
Hide resolved
| ); | ||
| } | ||
|
|
||
| function getMembershipFilter( |
There was a problem hiding this comment.
Shouldn't this be a Redux selector?
There was a problem hiding this comment.
Could be, I guess. Would this be by adding a new query to the roomMemberApi that filters membership events based on type and only return joins+invites? I can see how that would be optimal for rooms with high membership volume but it's also 10x more code... Maybe there's a simpler way I'm missing?
packages/react-sdk/src/components/FallbackSnapshotProvider/FallbackSnapshotProvider.tsx
Outdated
Show resolved
Hide resolved
packages/react-sdk/src/components/FallbackSnapshotProvider/FallbackSnapshotProvider.tsx
Outdated
Show resolved
Hide resolved
packages/react-sdk/src/components/FallbackSnapshotProvider/FallbackSnapshotProvider.tsx
Outdated
Show resolved
Hide resolved
packages/react-sdk/src/components/FallbackSnapshotProvider/FallbackSnapshotProvider.tsx
Outdated
Show resolved
Hide resolved
mgcm
force-pushed
the
nic/feat/NEO-925-snapshot-on-invite-or-join
branch
from
99b93dc to
f3e0c69
Compare
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
mgcm
force-pushed
the
nic/feat/NEO-925-snapshot-on-invite-or-join
branch
from
db0f9c0 to
3c3652c
Compare
weeman1337
requested changes
Nov 21, 2024
weeman1337
reviewed
Nov 25, 2024
| export const App = ({ layoutProps }: AppProps) => { | ||
| const { t } = useTranslation('neoboard'); | ||
| const { value, loading } = useOwnedWhiteboard(); | ||
| const whiteboardManager = useWhiteboardManager(); | ||
| const ownUserId = useWidgetApi().widgetParameters.userId; | ||
| const whiteboardInstance = useActiveWhiteboardInstance(); |
There was a problem hiding this comment.
This breaks NeoBoard standalone. Can you have a look?
weeman1337
reviewed
Nov 25, 2024
| validator: isValidWhiteboardDocumentSnapshot, | ||
| }); | ||
|
|
||
| const handlePersist = useCallback(() => { |
There was a problem hiding this comment.
Would be nice if the entire logic is split out, e.g. into a hook or function. Otherwise App becomes really cluttered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ Checklist
Signed-off-byline in the message (more info).