NEO-1075: Shapes have a minimum size enforced on creation / loading #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d6ae3eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
weeman1337
previously requested changes
Dec 19, 2024
mgcm
force-pushed
the
nic/bugfix/NEO-1075
branch
from
fc373bb to
ebf9a9f
Compare
mgcm
changed the title
mgcm
reviewed
Jan 2, 2025
packages/react-sdk/src/components/Whiteboard/ElementBehaviors/Text/TextElement.tsx
Show resolved
Hide resolved
mgcm
reviewed
Jan 2, 2025
mgcm
reviewed
Jan 2, 2025
ahmadkadri
approved these changes
Jan 3, 2025
Signed-off-by: Christian Paul <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
mgcm
force-pushed
the
nic/bugfix/NEO-1075
branch
from
d0bd5ba to
d6ae3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already enforce this minimum size when resizing. Now, it's also enforced while.
I couldn't find the code that enforces the minimum size when reszing. Would be great to use the same code / values / constant here.
✔️ Checklist
Signed-off-byline in the message (more info).