Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve devtools more #661

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve devtools more #661

wants to merge 5 commits into from

Conversation

HarHarLinks
Copy link
Contributor

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

image

@HarHarLinks HarHarLinks requested a review from a team as a code owner December 5, 2024 17:51
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: cda1788

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works. Some smaller comments.

If touching this, can we fix the size:

image

The size is getting lower if you add more Elements to the board :D
https://github.com/nordeck/matrix-neoboard/pull/661/files#diff-84889a984e5272eb7cf18db4e6a51643a897fcdc19c9de40d85a0082fa12493bL72

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Dec 6, 2024

can we fix the size

it is not a size. it is the ratio of binary size to json size (whatever that means exactly). i.e. if you subtract 1 it is the overhead of the whole encoding crdt etc stuff

The size is getting lower if you add more Elements to the board :D

The overhead is getting lower, as expected.

@weeman1337
Copy link
Contributor

can we fix the size

it is not a size. it is the ratio of binary size to json size (whatever that means exactly). i.e. if you subtract 1 it is the overhead of the whole encoding crdt etc stuff

The size is getting lower if you add more Elements to the board :D

The overhead is getting lower, as expected.

„whatever that means exactly“ 🤷

@HarHarLinks
Copy link
Contributor Author

suggest what to do with it? "fix" is not very precise

@HarHarLinks HarHarLinks force-pushed the nic/feat/NEO-1058-part2 branch from f4a08b3 to 1d348fd Compare December 6, 2024 14:34
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new error message in the console when dev tools are open:

Warning: Received `true` for a non-boolean attribute `monospace`.

If you want to write it to the DOM, pass a string instead: monospace="true" or monospace={value.toString()}.
td

Can you have a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants