-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve devtools more #661
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works. Some smaller comments.
If touching this, can we fix the size:
The size is getting lower if you add more Elements to the board :D
https://github.com/nordeck/matrix-neoboard/pull/661/files#diff-84889a984e5272eb7cf18db4e6a51643a897fcdc19c9de40d85a0082fa12493bL72
packages/react-sdk/src/components/DeveloperTools/DeveloperToolsDialog.tsx
Outdated
Show resolved
Hide resolved
packages/react-sdk/src/components/DeveloperTools/WhiteboardSessions.tsx
Outdated
Show resolved
Hide resolved
it is not a size. it is the ratio of binary size to json size (whatever that means exactly). i.e. if you subtract 1 it is the overhead of the whole encoding crdt etc stuff
The overhead is getting lower, as expected. |
„whatever that means exactly“ 🤷 |
suggest what to do with it? "fix" is not very precise |
f4a08b3
to
1d348fd
Compare
Signed-off-by: Kim Brose <[email protected]>
Signed-off-by: Kim Brose <[email protected]>
Signed-off-by: Kim Brose <[email protected]>
Signed-off-by: Kim Brose <[email protected]>
Signed-off-by: Kim Brose <[email protected]>
2af792d
to
cda1788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a new error message in the console when dev tools are open:
Warning: Received `true` for a non-boolean attribute `monospace`.
If you want to write it to the DOM, pass a string instead: monospace="true" or monospace={value.toString()}.
td
Can you have a look at this?
✔️ Checklist
Signed-off-by
line in the message (more info).