NEO-954: "no snapshot available" dialog #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e320822 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mgcm
force-pushed
the
nic/feat/NEO-954-no-snapshot-available-dialog
branch
3 times, most recently
from
c1ba91e to
ae27647
Compare
HarHarLinks
reviewed
Jan 10, 2025
maheichyk
requested changes
Jan 13, 2025
packages/react-sdk/src/components/connection-state/ConnectionStateProvider.tsx
Outdated
Show resolved
Hide resolved
packages/react-sdk/src/components/connection-state/SnapshotLoadStateDialog.tsx
Show resolved
Hide resolved
mgcm
force-pushed
the
nic/feat/NEO-954-no-snapshot-available-dialog
branch
2 times, most recently
from
e279db3 to
42c696b
Compare
mgcm
force-pushed
the
nic/feat/NEO-954-no-snapshot-available-dialog
branch
3 times, most recently
from
470adf1 to
62e7d30
Compare
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Co-authored-by: Kim Brose <[email protected]> Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
Signed-off-by: Milton Moura <[email protected]>
mgcm
force-pushed
the
nic/feat/NEO-954-no-snapshot-available-dialog
branch
from
c9a34f3 to
f3b9a67
Compare
added 3 commits
January 21, 2025 09:39
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
added 3 commits
January 21, 2025 10:04
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
maheichyk
approved these changes
Jan 21, 2025
HarHarLinks
added a commit
that referenced
this pull request
Jan 21, 2025
* Refactored connectionInfoState to snapshotInfoState Signed-off-by: Milton Moura <[email protected]> * Draft implementation Signed-off-by: Milton Moura <[email protected]> * Show blocking dialog when unable to load a snapshot from room history Signed-off-by: Milton Moura <[email protected]> * Remove logging and add support for embedded mode Signed-off-by: Milton Moura <[email protected]> * Changes load failure dispatching and associated tests Signed-off-by: Milton Moura <[email protected]> * Update dialog message to something more adequate Signed-off-by: Milton Moura <[email protected]> * Add changeset Signed-off-by: Milton Moura <[email protected]> * Update .changeset/eleven-pans-pull.md Co-authored-by: Kim Brose <[email protected]> Signed-off-by: Milton Moura <[email protected]> * Applying review feedback Signed-off-by: Milton Moura <[email protected]> * Applying further review feedback Signed-off-by: Milton Moura <[email protected]> * Preparing for merge Signed-off-by: Milton Moura <[email protected]> * Rolling back on the connection state store refactor Signed-off-by: Milton Moura <[email protected]> * Move snapshotInfoSlice.ts code into connectionInfoSlice.ts. Signed-off-by: Mikhail Aheichyk <[email protected]> * Fix typo in name Signed-off-by: Mikhail Aheichyk <[email protected]> * Smaller test text changes Signed-off-by: Mikhail Aheichyk <[email protected]> * Add variable Signed-off-by: Mikhail Aheichyk <[email protected]> * Rename snapshotFailed to snapshotSaveFailed Signed-off-by: Mikhail Aheichyk <[email protected]> * Rename setSnapshotSuccessful to setSnapshotSaveSuccessful Signed-off-by: Mikhail Aheichyk <[email protected]> --------- Signed-off-by: Milton Moura <[email protected]> Signed-off-by: Mikhail Aheichyk <[email protected]> Co-authored-by: Kim Brose <[email protected]> Co-authored-by: Mikhail Aheichyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A blocking information dialog will now be shown when the
net.nordeck.whiteboard.document.createevent is not readable due to a user joining rooms where message history is not available.This will happen in rooms where history is shared only after invite or join. It also applies to encrypted rooms where message keys are not shared for past events.
✔️ Checklist
Signed-off-byline in the message (more info).