Handle pasted image files #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a77a5cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
weeman1337
reviewed
Jan 9, 2025
packages/react-sdk/src/components/Shortcuts/ClipboardShortcuts/ClipboardShortcuts.tsx
Show resolved
Hide resolved
jaller94
force-pushed
the
nic/feat/NEO-683
branch
from
6457d7a to
25a07f6
Compare
weeman1337
requested changes
Jan 15, 2025
There was a problem hiding this comment.
- We still do not use our upload code, that contains all our logic
- A changeset is missing
I've sketched how we can reuse our code here https://github.com/nordeck/matrix-neoboard/compare/nic/feat/NEO-683-paste-image-upload?expand=1
It factors out one function and then just use what we currently do for image uploads.
jaller94
force-pushed
the
nic/feat/NEO-683
branch
from
ef945cc to
d0e3de0
Compare
Signed-off-by: Christian Paul <[email protected]>
… in one interaction, so Undo and Redo work as expected Signed-off-by: Christian Paul <[email protected]>
Signed-off-by: Christian Paul <[email protected]>
Signed-off-by: Christian Paul <[email protected]>
Signed-off-by: Christian Paul <[email protected]>
HarHarLinks
force-pushed
the
nic/feat/NEO-683
branch
from
82cdba1 to
a77a5cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ Checklist
Signed-off-byline in the message (more info).