Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improved SBOM reports #716

Merged
merged 8 commits into from
Jan 17, 2025
Merged

Add improved SBOM reports #716

merged 8 commits into from
Jan 17, 2025

Conversation

mgcm
Copy link
Contributor

@mgcm mgcm commented Jan 14, 2025

This PR improves the SBOM reporting process by:

  • adding a yarn.lock SBOM scan report within the hosted widget assets at <URL>/sbom.spdx.json
  • adding an image SBOM scan report artifact to every CI build (see example)
  • adding an image SBOM scan report as a release asset when publishing a new release

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 24464fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nordeck/matrix-neoboard-widget Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mgcm mgcm force-pushed the nic/feat/ZO-132-improve-sbom branch 5 times, most recently from def307d to e1c1efb Compare January 15, 2025 12:36
@mgcm mgcm marked this pull request as ready for review January 15, 2025 13:09
@mgcm mgcm requested a review from a team January 15, 2025 13:09
@mgcm mgcm force-pushed the nic/feat/ZO-132-improve-sbom branch 2 times, most recently from 8d6d9a4 to adede9d Compare January 15, 2025 13:56
Copy link
Contributor

@maheichyk maheichyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just found typo.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@mgcm mgcm force-pushed the nic/feat/ZO-132-improve-sbom branch from 5a8f257 to 24464fe Compare January 16, 2025 16:26
@mgcm mgcm merged commit d068928 into main Jan 17, 2025
5 checks passed
@mgcm mgcm deleted the nic/feat/ZO-132-improve-sbom branch January 17, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants