Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WidgetApi.sendStateEvent to return the Matrix widget Api result. #870

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

weeman1337
Copy link
Contributor

Before, it waited for the same event sent back over the Widget API. If the was not updated, there was no such event.
Now sendStateEvent returns the response of the Matrix Widget Api with the event ID, among other things.

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: bccf812

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@matrix-widget-toolkit/api Major
@matrix-widget-toolkit/mui Patch
@matrix-widget-toolkit/react Patch
@matrix-widget-toolkit/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@weeman1337 weeman1337 force-pushed the nic/fix/NEO-1054-send-state-event branch 2 times, most recently from 6af4e9f to 999d4f8 Compare December 3, 2024 12:57
@weeman1337 weeman1337 marked this pull request as ready for review December 3, 2024 14:23
@weeman1337 weeman1337 requested a review from a team as a code owner December 3, 2024 14:23
@weeman1337 weeman1337 force-pushed the nic/fix/NEO-1054-send-state-event branch from 999d4f8 to da2c499 Compare December 3, 2024 14:32
Copy link
Contributor

@ahmadkadri ahmadkadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Before, it waited for the same event sent back over the Widget API.
If the was not updated, there was no such event.
Now sendStateEvent returns the response of the Matrix Widget Api
with the event ID, among other things.

Signed-off-by: Michael Weimann <[email protected]>
@weeman1337 weeman1337 force-pushed the nic/fix/NEO-1054-send-state-event branch from da2c499 to bccf812 Compare December 9, 2024 11:55
@weeman1337 weeman1337 enabled auto-merge (rebase) December 9, 2024 11:56
@weeman1337 weeman1337 merged commit 76314a9 into main Dec 9, 2024
4 checks passed
@weeman1337 weeman1337 deleted the nic/fix/NEO-1054-send-state-event branch December 9, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants