Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix JSON structure returned by 'daily_logs' endpoint #171

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

nortaljevgenikr
Copy link
Contributor

@nortaljevgenikr nortaljevgenikr commented Feb 10, 2025

Fixes for daily_logs endpoint:

  1. JSON result: added outer element, namely - array notation (outer-most brackets - [ and ])
  2. JSON result: array elements are now separated with commas {...}{...}{...} -> {...},{...},{...}
  3. In case when there are no results: instead of an empty archive producing error There was an error while extracting <filename>: empty archive, now the contents are an empty (but valid) JSON ([]).

Refs: OPMONDEV-193

@nortaljevgenikr nortaljevgenikr force-pushed the OPMONDEV-193_fix_daily_logs_json branch from b919cd3 to 7a5244e Compare February 11, 2025 10:03
@nortaljevgenikr nortaljevgenikr changed the title fix JSON structure returned by 'daily_logs' endpoint fix: Fix JSON structure returned by 'daily_logs' endpoint Feb 11, 2025
@nortaljevgenikr nortaljevgenikr marked this pull request as ready for review February 11, 2025 10:38
Copy link
Contributor

@raits raits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nortaljevgenikr nortaljevgenikr merged commit 33767a8 into develop Feb 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants