Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate nord.tmux file to ZSH shell #55

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

moritzdietz
Copy link

Knowing that most folks run bash as their primary shell, I wanted to create this PR in respect to Apples latest changes to their default shell for new installations. They made the new default shell ZSH and with that PR I've migrated the shell script part of this theme from Bash to ZSH.

Nothing much really, but I thought some might be interested in this.
Not sure where this would live in the theme - separate branch, different file, script that checks for which shell is the primary shell and then switch to that, …

HTH

@moritzdietz moritzdietz marked this pull request as draft January 23, 2021 15:21
@moritzdietz
Copy link
Author

There is still an issue with the commit 4e2dc2a.
image

@moritzdietz moritzdietz force-pushed the moritzdietz/migrate-to-zsh branch from cffd979 to 005e463 Compare January 23, 2021 15:45
@moritzdietz
Copy link
Author

I just found the issue. It was due to conditional expressions (http://zsh.sourceforge.net/Doc/Release/Conditional-Expressions.html).
Needed an additional pair of brackets.

@moritzdietz moritzdietz marked this pull request as ready for review January 23, 2021 15:48
@moritzdietz moritzdietz force-pushed the moritzdietz/migrate-to-zsh branch from 005e463 to c9a7f9b Compare January 23, 2021 15:49
@svengreb svengreb self-requested a review as a code owner April 10, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant