Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#39): correct result typing #40

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix(#39): correct result typing #40

merged 2 commits into from
Sep 18, 2024

Conversation

ohai89
Copy link
Contributor

@ohai89 ohai89 commented Sep 13, 2024

Fixes #39

@dbarrosop
Copy link
Contributor

Hello,
thanks a lot for the PR. This looks good to me, unfortunately we need to look at the CI which is a bit outdated right now :(

@dbarrosop
Copy link
Contributor

Now that @ogenstad was kind enough to fix the CI I am merging this.

@dbarrosop dbarrosop merged commit 38f8036 into nornir-automation:master Sep 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarrosop dbarrosop dbarrosop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pyright reports print_result() not able to handle AggregatedResult and Multiresult
2 participants
@ohai89 @dbarrosop