-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nan to latest version. #56
base: master
Are you sure you want to change the base?
Conversation
Thank you @travispaul. |
My bad, I actually missed a compile error even with the fix:
|
@stoneLeaf I've encountered that with v22 recently too (didn't see that error on v20 though), I have a fix here: travispaul@6445d7d |
I can confirm it's working under Node 22 with your fix @travispaul, thanks a lot! |
Yep, makes sense. I'm planning to fork this library for work at some point in the future (unless activity picks back up), but its not highest priority at the moment. If/when we do fork it, we'll also remove all the non-windows features in our fork (we'll handle *nix daemons through other means) and keep it working with latest and LTS Node versions. |
I only need it for Windows too so I'll keep an eye out for your fork if it happens and you keep it public. |
Fixes #55