Update changes for pay_invoice, multi_pay_invoice, multi_pay_keysend #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pay_invoice: Request description grammar error multi_pay_invoice: Request description grammar error multi_pay_keysend: Response description grammar error
AsaiToshiya
reviewed
Nov 27, 2024
Co-authored-by: Asai Toshiya <[email protected]>
|
Do you still fins any conflicts with this? |
Semisol
reviewed
Jan 1, 2025
| @@ -247,7 +247,7 @@ Request: | |||
| Response: | |||
|
|
|||
| For every keysend in the request, a separate response event is sent. To differentiate between the responses, each | |||
| response event contains an `d` tag with the id of the keysend it is responding to, if no id was given, then the | |||
There was a problem hiding this comment.
This is the only one that makes sense. The others are intentional: the NWC server is a payment provider, not the user being asked to pay
There was a problem hiding this comment.
ok, would probably only make that change then
Semisol
reviewed
Jan 5, 2025
| @@ -128,7 +128,7 @@ nostr+walletconnect://b889ff5b1513b641e2a139f661a661364979c5beee91842f8f0ef42ab5 | |||
|
|
|||
| ### `pay_invoice` | |||
|
|
|||
| Description: Requests payment of an invoice. | |||
| Description: Requests payment for an invoice. | |||
There was a problem hiding this comment.
Suggested change
| Description: Requests payment for an invoice. | |
| Description: Requests payment of an invoice. |
| @@ -157,7 +157,7 @@ Errors: | |||
|
|
|||
| ### `multi_pay_invoice` | |||
|
|
|||
| Description: Requests payment of multiple invoices. | |||
| Description: Requests payment for multiple invoices. | |||
There was a problem hiding this comment.
Suggested change
| Description: Requests payment for multiple invoices. | |
| Description: Requests payment of multiple invoices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pay_invoice: Request description grammar error
multi_pay_invoice: Request description grammar error
multi_pay_keysend: Response description grammar error