-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unauthenticated uploads from the API (will be merged on {postponed again}) #70
Conversation
I'm pretty sure we're using the pfp endpoint unauthenticated for mutiny profile image uploads. Need to double check with @benthecarman next week. |
If it will be a problem, I will exclude pfp from the auth path and allow for unauthenticated uploads - |
Nos is currently using unauthenticated uploads to |
Mutiny has deployed this change. |
I pushed it to 7/1 to allow you time to plan. Sorry about that, didn’t mean to put unnecessary pressure |
@fishcakeday thank you. We deployed a production build of Nos that uses NIP-98 authentication today. |
@v0l is snort authenticating to nostr.build with nip98? |
@mattn are you also good with this one? Do you know anyone else who might get affected? I am still delaying to make sure I do not break anyone. |
@syusui-s are you using nip98 for uploads at https://rabbit.syusui.net/ ? Do you know anyone else who might get affected? |
Currently, I have two bots posts images to nostr.build. But I don't mind you will change the APIs. |
Can you please add nip98 to the bots? The API is the same, just add the nip98 auth header and you are good. |
Thank you for letting me know. Rabbit doesn't support NIP-98 as for now. I will support NIP-98 soon.
I don't know... Most of all Japanese clients support NIP-98 as far as I know. |
@fishcakeday Now I fixed two bots to use NIP-98. |
BTW, nostr.build will be possible to delete image which was posted by same pubkey with NIP-98? |
Yes, I just need to implement it. Probably in 2-3 weeks. |
@mattn I have deployed the initial implementation on staging.nostr.build that (should) support deletion using standard nip96 approach. Do you mind testing it and letting me know if it works? Thank you in advance. |
It's deployed now and ready to use. |
To combat spam and illegal uploads, we will deprecate unauthenticated uploads.