-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows-install.md #117
Conversation
- Added more information for KVM missing support for AMD in Windows 10.
Reviewer's Guide by SourceryThis pull request updates the windows-install.md file to provide more accurate information about KVM support for AMD processors on Windows. The changes include a minor grammatical correction and the addition of a new section addressing the lack of KVM support for AMD processors on Windows 10. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArsenicBismuth - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider clarifying that the Windows 10 limitation for AMD processors is specific to nested virtualization, not KVM extensions in general. This could help prevent confusion for users unfamiliar with the distinctions between virtualization features.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
### Getting `Your CPU does not support KVM extensions` on AMD processors | ||
|
||
For those with AMD EPYC/Ryzen processor or later, Nested Virtualization (required for KVM) [is not supported on Windows 10](https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/user-guide/enable-nested-virtualization#amd-epyc--ryzen-processor-or-later). So you have to upgrade to Windows 11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider adding a note earlier in the document about the AMD-specific information.
This would help AMD users find this important information more easily without disrupting the main flow of the document.
### Getting `Your CPU does not support KVM extensions` on AMD processors | |
For those with AMD EPYC/Ryzen processor or later, Nested Virtualization (required for KVM) [is not supported on Windows 10](https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/user-guide/enable-nested-virtualization#amd-epyc--ryzen-processor-or-later). So you have to upgrade to Windows 11. | |
### CPU Compatibility Note | |
> **AMD Users**: Nested Virtualization (required for KVM) is not supported on Windows 10 for AMD EPYC/Ryzen processors. Windows 11 is required. See [AMD-specific details](#getting-your-cpu-does-not-support-kvm-extensions-on-amd-processors) below. | |
... | |
### Getting `Your CPU does not support KVM extensions` on AMD processors | |
For those with AMD EPYC/Ryzen processor or later, upgrade to Windows 11 to use Nested Virtualization with KVM. |
Thanks again! |
Added more information for KVM missing support for AMD in Windows 10: https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/user-guide/enable-nested-virtualization#amd-epyc--ryzen-processor-or-later
Was a bit confused, but it seems like there's no workaround regarding this, other than just upgrade your OS to W11. Enabling Hyper-V and setting
nestedVirtualization=true
won't do anything since it's unsupported in any way.Summary by Sourcery
Update the documentation to clarify that AMD EPYC/Ryzen processors require an upgrade to Windows 11 for Nested Virtualization support, as it is not available on Windows 10.
Documentation: