noto_lint update #518
Open
noto_lint update #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notofonts#1- Updated the COPYRIGHT regex expression to return match if: A- COPYRIGHT string contain years range or single year B- COPYRIGHT string contain Google LLC or Google Inc. C- COPYRIGHT string contain 'Rights Reserved' or 'rights reserved' notofonts#2- Added some exceptions for NotoSerifDisplay and NotoSansfDisplay to check the font name correctly notofonts#3- Updated _SHORT_SCRIPTS list, deleted/edited second review may needed notofonts#4- Updated the version check notofonts#5- Updated the trademark check module, now will use regex to match both LLC or Inc. notofonts#6- Added new manufacturers notofonts#7- Added new mono type designer
Added manufacturer Ek Type and JamraPatel LLC Suggested delete adding display to display fonts
Fixed NotoSansNKo hard coded script name
Added NotoSansTamilSupplement to the list
NotoSansTamilSupplement added, unicode data should be added too
|
@marekjez86 please review the changes. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer Font data added
Manufacturer added/updated
Designer added/updated
Copyright matching criteria updated
Other bugs fixed