minor refactor and natspec

nounsDAO · Dec 3, 2024 · eaab477 · eaab477
1 parent a1d38e3
commit eaab477
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/nouns-contracts/contracts/StreamEscrow.sol b/packages/nouns-contracts/contracts/StreamEscrow.sol
@@ -73,9 +73,10 @@ contract StreamEscrow is IStreamEscrow {
         address streamCreator_,
         uint32 minimumTickDuration_
     ) {
+        require(nounsRecipient_ != address(0), 'zero address');
+
         daoExecutor = daoExecutor_;
         ethRecipient = ethRecipient_;
-        require(nounsRecipient_ != address(0), 'zero address');
         nounsRecipient = nounsRecipient_;
         nounsToken = INounsToken(nounsToken_);
         allowedToCreateStream[streamCreator_] = true;
@@ -278,6 +279,7 @@ contract StreamEscrow is IStreamEscrow {
 
     /**
      * @notice Allows the DAO to set the address that the Nouns tokens will be sent to when streams are canceled.
+     * The zero address is not allowed because it will cause the transfer to revert, which will cause all cancellations to revert.
      */
     function setNounsRecipient(address newAddress) external onlyDAO {
         require(newAddress != address(0), 'zero address');