DRAFT: fix audit issue 184 #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will cause cancels to revert
davidbrai
changed the base branch from
master
to
verbs-stream-escrow-nouner-can-create-stream
✅ Deploy Preview for nouns-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nouns-home ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
eladmallel
reviewed
Dec 3, 2024
| @@ -75,6 +75,7 @@ contract StreamEscrow is IStreamEscrow { | |||
| ) { | |||
| daoExecutor = daoExecutor_; | |||
| ethRecipient = ethRecipient_; | |||
| require(nounsRecipient_ != address(0), 'zero address'); | |||
There was a problem hiding this comment.
can you please put this requirement at the top of the function?
eladmallel
reviewed
Dec 3, 2024
| @@ -279,6 +280,7 @@ contract StreamEscrow is IStreamEscrow { | |||
| * @notice Allows the DAO to set the address that the Nouns tokens will be sent to when streams are canceled. | |||
| */ | |||
| function setNounsRecipient(address newAddress) external onlyDAO { | |||
| require(newAddress != address(0), 'zero address'); | |||
There was a problem hiding this comment.
can you please add natspec that explains why we aren't accepting zero address, i.e. explain the potential griefing scenario briefly? something like:
"newAddress cannot be the zero address because that would cause all stream cancellations to revert, since the Nouns token contract does not permit sending tokens to the zero address"
eladmallel
approved these changes
Dec 3, 2024
davidbrai
merged commit 4285edb
into
verbs-stream-escrow-nouner-can-create-stream
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.