-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DUNA admin comms onchain #877
Draft
eladmallel
wants to merge
5
commits into
verbs-auction-sanction-check
Choose a base branch
from
verbs-duna-admin-onchain-comms
base: verbs-auction-sanction-check
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2e1e585
data: initial commit of duna admin comms
eladmallel 4f945a5
data: add some tests to duna admin comms
eladmallel ff5d73b
data: fix natspec todo
eladmallel 267f0a0
data: duna admin can also replace duna admin address
eladmallel b876703
data: mainnet fork test with happy flows
eladmallel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
packages/nouns-contracts/contracts/governance/data/NounsDAODataEventsV1.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
// SPDX-License-Identifier: GPL-3.0 | ||
|
||
/// @title Nouns DAO Data Events | ||
|
||
/********************************* | ||
* ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ * | ||
* ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ * | ||
* ░░░░░░█████████░░█████████░░░ * | ||
* ░░░░░░██░░░████░░██░░░████░░░ * | ||
* ░░██████░░░████████░░░████░░░ * | ||
* ░░██░░██░░░████░░██░░░████░░░ * | ||
* ░░██░░██░░░████░░██░░░████░░░ * | ||
* ░░░░░░█████████░░█████████░░░ * | ||
* ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ * | ||
* ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ * | ||
*********************************/ | ||
|
||
pragma solidity ^0.8.19; | ||
|
||
contract NounsDAODataEventsV1 { | ||
event ProposalCandidateCreated( | ||
address indexed msgSender, | ||
address[] targets, | ||
uint256[] values, | ||
string[] signatures, | ||
bytes[] calldatas, | ||
string description, | ||
string slug, | ||
uint256 proposalIdToUpdate, | ||
bytes32 encodedProposalHash | ||
); | ||
event ProposalCandidateUpdated( | ||
address indexed msgSender, | ||
address[] targets, | ||
uint256[] values, | ||
string[] signatures, | ||
bytes[] calldatas, | ||
string description, | ||
string slug, | ||
uint256 proposalIdToUpdate, | ||
bytes32 encodedProposalHash, | ||
string reason | ||
); | ||
event ProposalCandidateCanceled(address indexed msgSender, string slug); | ||
event SignatureAdded( | ||
address indexed signer, | ||
bytes sig, | ||
uint256 expirationTimestamp, | ||
address proposer, | ||
string slug, | ||
uint256 proposalIdToUpdate, | ||
bytes32 encodedPropHash, | ||
bytes32 sigDigest, | ||
string reason | ||
); | ||
event FeedbackSent(address indexed msgSender, uint256 proposalId, uint8 support, string reason); | ||
event CandidateFeedbackSent( | ||
address indexed msgSender, | ||
address indexed proposer, | ||
string slug, | ||
uint8 support, | ||
string reason | ||
); | ||
event CreateCandidateCostSet(uint256 oldCreateCandidateCost, uint256 newCreateCandidateCost); | ||
event UpdateCandidateCostSet(uint256 oldUpdateCandidateCost, uint256 newUpdateCandidateCost); | ||
event ETHWithdrawn(address indexed to, uint256 amount); | ||
event FeeRecipientSet(address indexed oldFeeRecipient, address indexed newFeeRecipient); | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eladmallel why do we need the previous contracts version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it later once we feel like we're done