Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expires_at parsing; add support for cancellation_date #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion lib/itunes/receipt.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ def initialize(attributes = {})
:bid,
:bundle_id,
:bvrs,
:cancellation_date,
:cancellation_date_ms,
:cancellation_date_pst,
:download_id,
:expires_date,
:expires_date_ms,
:expires_date_pst,
:in_app,
:is_trial_period,
:itunes_env,
Expand All @@ -47,6 +52,7 @@ def initialize(attributes = {})
:request_date_pst,
:transaction_id,
:version_external_identifier,
:web_order_line_item_id
)

def initialize(attributes = {})
Expand All @@ -57,9 +63,24 @@ def initialize(attributes = {})
@bid = receipt_attributes[:bid]
@bundle_id = receipt_attributes[:bundle_id]
@bvrs = receipt_attributes[:bvrs]
@cancellation_date = if receipt_attributes[:cancellation_date]
Time.parse receipt_attributes[:cancellation_date].sub('Etc/GMT', 'GMT')
end
@cancellation_date_ms = if receipt_attributes[:cancellation_date_ms]
receipt_attributes[:cancellation_date_ms].to_i
end
@cancellation_date_pst = if receipt_attributes[:cancellation_date_pst]
Time.parse receipt_attributes[:cancellation_date_pst].sub('America/Los_Angeles', 'PST')
end
@download_id = receipt_attributes[:download_id]
@expires_date = if receipt_attributes[:expires_date]
Time.at(receipt_attributes[:expires_date].to_i / 1000)
Time.parse receipt_attributes[:expires_date].sub('Etc/GMT', 'GMT')
end
@expires_date_ms = if receipt_attributes[:expires_date_ms]
receipt_attributes[:expires_date_ms].to_i
end
@expires_date_pst = if receipt_attributes[:expires_date_pst]
Time.parse receipt_attributes[:expires_date_pst].sub('America/Los_Angeles', 'PST')
end
@in_app = if receipt_attributes[:in_app]
receipt_attributes[:in_app].map { |ia| self.class.new(:receipt => ia) }
Expand Down Expand Up @@ -120,6 +141,7 @@ def initialize(attributes = {})
end
@transaction_id = receipt_attributes[:transaction_id]
@version_external_identifier = receipt_attributes[:version_external_identifier]
@web_order_line_item_id = receipt_attributes[:web_order_line_item_id]
end

def application_receipt?
Expand Down
2 changes: 1 addition & 1 deletion spec/fake_json/autorenew_subscription.json
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
{"receipt":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d69cc362c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date":"1350157508197", "transaction_id":"1000000055076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000026553289", "bvrs":"1.0", "expires_date_formatted":"2012-10-13 19:45:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208197", "expires_date_formatted_pst":"2012-10-13 12:45:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "latest_receipt_info":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d79cc562c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date":"1350157808000", "transaction_id":"1000000052076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000027293289", "bvrs":"1.0", "expires_date_formatted":"2012-10-13 19:50:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208000", "expires_date_formatted_pst":"2012-10-13 12:50:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "status":0, "latest_receipt":"junk="}
{"receipt":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d69cc362c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date_ms":"1350157508197", "transaction_id":"1000000055076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000026553289", "bvrs":"1.0", "expires_date":"2012-10-13 19:45:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208197", "expires_date_pst":"2012-10-13 12:45:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "latest_receipt_info":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d79cc562c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date_ms":"1350157808000", "transaction_id":"1000000052076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000027293289", "bvrs":"1.0", "expires_date":"2012-10-13 19:50:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208000", "expires_date_pst":"2012-10-13 12:50:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "status":0, "latest_receipt":"junk="}

2 changes: 2 additions & 0 deletions spec/fake_json/autorenew_subscription_cancelled.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
{"receipt":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d69cc362c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date_ms":"1350157508197", "cancellation_date":"2012-10-13 19:42:08 Etc/GMT", "cancellation_date_ms":"1350157328197", "cancellation_date_pst":"2012-10-13 12:42:08 America/Los_Angeles", "transaction_id":"1000000055076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000026553289", "bvrs":"1.0", "expires_date":"2012-10-13 19:45:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208197", "expires_date_pst":"2012-10-13 12:45:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "latest_receipt_info":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d79cc562c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date_ms":"1350157808000", "cancellation_date":"2012-10-13 19:42:08 Etc/GMT", "cancellation_date_ms":"1350157328197", "cancellation_date_pst":"2012-10-13 12:42:08 America/Los_Angeles", "transaction_id":"1000000052076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000027293289", "bvrs":"1.0", "expires_date":"2012-10-13 19:50:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208000", "expires_date_pst":"2012-10-13 12:50:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "status":0, "latest_receipt":"junk="}

2 changes: 1 addition & 1 deletion spec/fake_json/autorenew_subscription_expired.json
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
{"receipt":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d69cc362c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date":"1350157508197", "transaction_id":"1000000055076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000026553289", "bvrs":"1.0", "expires_date_formatted":"2012-10-13 19:45:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208197", "expires_date_formatted_pst":"2012-10-13 12:45:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "latest_receipt_info":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d79cc562c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date":"1350157808000", "transaction_id":"1000000052076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000027293289", "bvrs":"1.0", "expires_date_formatted":"2012-10-13 19:50:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208000", "expires_date_formatted_pst":"2012-10-13 12:50:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "status":21006, "latest_receipt":"junk="}
{"receipt":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d69cc362c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date_ms":"1350157508197", "transaction_id":"1000000055076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000026553289", "bvrs":"1.0", "expires_date":"2012-10-13 19:45:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208197", "expires_date_pst":"2012-10-13 12:45:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "latest_receipt_info":{"original_purchase_date_pst":"2012-10-11 07:45:40 America/Los_Angeles", "unique_identifier":"4d79cc562c5c58ce62da68ee43721ea670907bad", "original_transaction_id":"1000000057005439", "expires_date_ms":"1350157808000", "transaction_id":"1000000052076747", "quantity":"1", "product_id":"com.notkeepingitreal.fizzbuzz.subscription.autorenew1m", "original_purchase_date_ms":"1349966740000", "bid":"com.notkeepingitreal.fizzbuzz", "web_order_line_item_id":"1000000027293289", "bvrs":"1.0", "expires_date":"2012-10-13 19:50:08 Etc/GMT", "purchase_date":"2012-10-13 19:40:08 Etc/GMT", "purchase_date_ms":"1350157208000", "expires_date_pst":"2012-10-13 12:50:08 America/Los_Angeles", "purchase_date_pst":"2012-10-13 12:40:08 America/Los_Angeles", "original_purchase_date":"2012-10-11 14:45:40 Etc/GMT", "item_id":"570504929"}, "status":21006, "latest_receipt":"junk="}

24 changes: 24 additions & 0 deletions spec/itunes/receipt_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,12 @@
receipt.original.quantity.should be_nil
receipt.original.transaction_id.should == '1000000001479608'
receipt.original.purchase_date.should == Time.utc(2011, 2, 17, 6, 20, 57)
receipt.original.cancellation_date.should be_nil
receipt.expires_date.should be_nil
receipt.receipt_data.should be_nil
receipt.cancellation_date.should be_nil
receipt.itunes_env.should == :production
receipt.web_order_line_item_id.should be_nil

# Those attributes are not returned from iTunes Connect Sandbox
receipt.app_item_id.should be_nil
Expand Down Expand Up @@ -143,8 +146,10 @@
receipt.bid.should be_nil
receipt.bvrs.should be_nil
receipt.expires_date.should be_nil
receipt.cancellation_date.should be_nil
receipt.receipt_data.should be_nil
receipt.itunes_env.should == :production
receipt.web_order_line_item_id.should be_nil

# Those attributes are not returned from iTunes Connect Sandbox
receipt.app_item_id.should be_nil
Expand Down Expand Up @@ -172,7 +177,9 @@
receipt.original.transaction_id.should == original_transaction_id
receipt.original.purchase_date.should == original_purchase_date
receipt.expires_date.should == Time.utc(2012, 10, 13, 19, 45, 8)
receipt.cancellation_date.should be_nil
receipt.receipt_data.should be_nil
receipt.web_order_line_item_id.should == '1000000026553289'

# Those attributes are not returned from iTunes Connect Sandbox
receipt.app_item_id.should be_nil
Expand All @@ -185,12 +192,14 @@
latest.transaction_id.should == '1000000052076747'
latest.purchase_date.should == Time.utc(2012, 10, 13, 19, 40, 8)
latest.expires_date.should == Time.utc(2012, 10, 13, 19, 50, 8) # five minutes after the "old" receipt
latest.cancellation_date.should be_nil
latest.bid.should == 'com.notkeepingitreal.fizzbuzz'
latest.bvrs.should == '1.0'
latest.original.quantity.should be_nil
latest.original.transaction_id.should == original_transaction_id
latest.original.purchase_date.should == original_purchase_date
latest.receipt_data.should == 'junk='
receipt.web_order_line_item_id.should == '1000000026553289'

# Those attributes are not returned from iTunes Connect Sandbox
latest.app_item_id.should be_nil
Expand All @@ -213,6 +222,21 @@

end

context 'when cancelled autorenew subscription' do
before do
fake_json :autorenew_subscription_cancelled
end

it 'should return valid Receipt instance for autorenew subscription, with the cancellation_date field set' do
receipt = Itunes::Receipt.verify! 'autorenew_subscription_cancelled'
receipt.should be_instance_of Itunes::Receipt
receipt.purchase_date.should == Time.utc(2012, 10, 13, 19, 40, 8)
receipt.expires_date.should == Time.utc(2012, 10, 13, 19, 45, 8)
receipt.cancellation_date.should == Time.utc(2012, 10, 13, 19, 42, 8) # user cancelled via Apple Customer Support 2 minutes after their subscription began
end

end

context 'when offline' do
before do
fake_json :offline
Expand Down