Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: UI review #2762

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Fix: UI review #2762

wants to merge 7 commits into from

Conversation

tuul-wq
Copy link
Contributor

@tuul-wq tuul-wq commented Dec 2, 2024

  • Multiple UI fixes for Multisig flow

closes #2731

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Jest Unit tests results

Generic badge

Duration: 50.396 seconds
Start: 2024-12-03 12:09:08.464 UTC
Finish: 2024-12-03 12:09:58.860 UTC
Duration: 50.396 seconds
Outcome: Passed | Total Tests: 761 | Passed: 760 | Failed: 0
Total Test Suites: 158
Total Tests: 761
Failed Test Suites: 0
Failed Tests: 0
Passed Test Suites: 157
Passed Tests: 760
Pending Test Suites: 1
Pending Tests: 1

johnthecat
johnthecat requested changes Dec 2, 2024
View reviewed changes
src/renderer/pages/Onboarding/WatchOnly/WatchOnly.tsx Show resolved Hide resolved
src/renderer/shared/lib/utils/__tests__/address.test.ts Outdated Show resolved Hide resolved
src/renderer/shared/lib/utils/__tests__/address.test.ts Outdated Show resolved Hide resolved
src/renderer/shared/lib/utils/address.ts Outdated Show resolved Hide resolved
src/renderer/shared/lib/utils/chains.ts Outdated Show resolved Hide resolved
src/renderer/shared/ui-entities/AccountExplorer/AccountExplorers.tsx Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Combobox/Combobox.tsx
@@ -41,14 +42,24 @@ type InputProps = Pick<
>;

type ControlledPopoverProps = {
value: string;
selectedValue: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you need to differentiate selected value from value from input?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to store compound selected value it will also be visible in Combobox Input
To avoid this we separate input's value and selected one

inputValue={signatoryAddress}
selectedValue={`${signatoryAddress}_${selectedWalletId}`}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for Sergey's UI decision

src/renderer/widgets/CreateWallet/model/form-model.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asmadek Asmadek Asmadek approved these changes

@johnthecat johnthecat Awaiting requested review from johnthecat

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multisigs. Design review layout issues
3 participants
@tuul-wq @Asmadek @johnthecat