Fix: UI review #2762
Open
Fix: UI review #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest Unit tests resultsDuration: 50.396 seconds
Outcome: Passed | Total Tests: 761 | Passed: 760 | Failed: 0
|
tuul-wq
commented
Dec 2, 2024
tuul-wq
commented
Dec 2, 2024
tuul-wq
commented
Dec 2, 2024
tuul-wq
commented
Dec 2, 2024
johnthecat
requested changes
Dec 2, 2024
src/renderer/shared/ui-entities/AccountExplorer/AccountExplorers.tsx
Outdated
Show resolved
Hide resolved
| @@ -41,14 +42,24 @@ type InputProps = Pick< | |||
| >; | |||
|
|
|||
| type ControlledPopoverProps = { | |||
| value: string; | |||
| selectedValue: string; | |||
There was a problem hiding this comment.
Why you need to differentiate selected value from value from input?
There was a problem hiding this comment.
If we want to store compound selected value it will also be visible in Combobox Input
To avoid this we separate input's value and selected one
inputValue={signatoryAddress}
selectedValue={`${signatoryAddress}_${selectedWalletId}`}There was a problem hiding this comment.
Waiting for Sergey's UI decision
Asmadek
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2731