Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 20 #57

Merged
merged 1 commit into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: "16.x"
node-version: "20.x"

- name: Get cache path
id: yarn-cache-dir-path
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: "16.x"
node-version: "20.x"

- name: Get cache path
id: yarn-cache-dir-path
Expand Down
4 changes: 3 additions & 1 deletion .prettierrc.json
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
{}
{
"trailingComma": "es5"
}
2 changes: 1 addition & 1 deletion convert-sarif/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ inputs:
description: "Used for the correlator field in the SBOM format. Distinguishes independent Workflows."
default: ${{ format('{0}_{1}', github.workflow, github.job) }}
runs:
using: "node16"
using: "node20"
main: "../dist/nowsecure-convert-sarif/index.js"
branding:
icon: alert-triangle
Expand Down
2 changes: 1 addition & 1 deletion create-issues/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ inputs:
required: false
description: "The owner of the GitHub repository used to create issues. Defaults to the owner of the repo running the action"
runs:
using: "node16"
using: "node20"
main: "../dist/nowsecure-create-issues/index.js"
branding:
icon: alert-triangle
Expand Down
46 changes: 23 additions & 23 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,34 +12,34 @@
"test": "jest"
},
"engines": {
"node": ">=16"
"node": ">=20"
},
"devDependencies": {
"@types/jest": "29.5.1",
"@types/lodash": "4.14.195",
"@types/node": "17.0.7",
"@types/sarif": "2.1.4",
"@typescript-eslint/eslint-plugin": "5.59.7",
"@typescript-eslint/parser": "5.59.7",
"@vercel/ncc": "0.36.1",
"eslint": "8.41.0",
"genversion": "3.1.1",
"jest": "29.5.0",
"nock": "13.3.1",
"prettier": "2.8.8",
"ts-jest": "29.1.0",
"typescript": "5.0.4"
"@types/jest": "29.5.11",
"@types/lodash": "4.14.202",
"@types/node": "20.11.10",
"@types/sarif": "2.1.7",
"@typescript-eslint/eslint-plugin": "6.20.0",
"@typescript-eslint/parser": "6.20.0",
"@vercel/ncc": "0.38.1",
"eslint": "8.56.0",
"genversion": "3.2.0",
"jest": "29.7.0",
"nock": "13.5.1",
"prettier": "3.2.4",
"ts-jest": "29.1.2",
"typescript": "5.3.3"
},
"dependencies": {
"@actions/core": "1.10.0",
"@actions/github": "5.1.1",
"@actions/http-client": "2.1.0",
"@github/dependency-submission-toolkit": "1.2.10",
"@octokit/action": "5.0.5",
"liquidjs": "10.7.1",
"@actions/core": "1.10.1",
"@actions/github": "6.0.0",
"@actions/http-client": "2.2.0",
"@github/dependency-submission-toolkit": "2.0.3",
"@octokit/action": "6.0.7",
"liquidjs": "10.10.0",
"lodash": "4.17.21",
"octokit": "2.0.18",
"octokit": "3.1.2",
"ripgrep-js": "3.0.0",
"yaml": "2.3.1"
"yaml": "2.3.4"
}
}
9 changes: 6 additions & 3 deletions src/__tests__/__snapshots__/nowsecure-snapshot.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ exports[`Snapshot conversion can perform conversion 1`] = `
"id": "42",
},
"manifests": {
"Payload/Example.app/ExampleFramework/Info.plist": Manifest {
"Payload/Example.app/ExampleFramework/Info.plist": g {
"file": undefined,
"name": "Payload/Example.app/ExampleFramework/Info.plist",
"resolved": {
"pkg:cocoapods/[email protected]": {
Expand All @@ -23,7 +24,8 @@ exports[`Snapshot conversion can perform conversion 1`] = `
},
},
},
"Payload/Example.app/libexample.dylib": Manifest {
"Payload/Example.app/libexample.dylib": g {
"file": undefined,
"name": "Payload/Example.app/libexample.dylib",
"resolved": {
"pkg:generic/[email protected]": {
Expand All @@ -34,7 +36,8 @@ exports[`Snapshot conversion can perform conversion 1`] = `
},
},
},
"Podfile.lock": Manifest {
"Podfile.lock": g {
"file": undefined,
"name": "Podfile.lock",
"resolved": {
"pkg:cocoapods/[email protected]": {
Expand Down
6 changes: 5 additions & 1 deletion src/utils/github-issues.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ export class GitHubRepo {
* @param repoName name of the repo
* @param auth auth token (GitHub token or private token)
*/
constructor(public repoOwner: string, public repoName: string, auth: string) {
constructor(
public repoOwner: string,
public repoName: string,
auth: string
) {
this.octokit = new Octokit({ auth });
}

Expand Down
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"resolveJsonModule": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node"
"moduleResolution": "node",
},
"include": ["./src/**/*"],
"exclude": ["./node_modules/", "./lib/", "./dist/"]
"exclude": ["./node_modules/", "./lib/", "./dist/"],
}
2 changes: 1 addition & 1 deletion upload-app/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ inputs:
required: false
description: The type of analysis to perform on the application (full, static or dependencies)
runs:
using: "node16"
using: "node20"
main: "../dist/nowsecure-upload-app/index.js"
branding:
icon: alert-triangle
Expand Down
Loading
Loading