Refactor arp_responder to use arp_helper #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the code is copied from arp_responder.py
Refactor arp_responder to make it listen to arp_help's events instead
of openflow's PacketIn.
The meaning of eat_packet has changed. It used to mean to stop
processing PacketIn events, now it means to stop processing
arp_helper's events.
arp_responder used to flood packets even this wasn't true
if (a.prototype == arp.PROTO_TYPE_IP)
if a.hwtype == arp.HW_TYPE_ETHERNET:
Now it doesn't receive these packets as arp_helper filters them.
proto/arp_helper: Add 'flood' property to the events proto/arp_responder: Use it Event handlers cannot flood an ARP request because they do not receive the original packet. Adding an 'ofp' property to the events would have been more flexible, but this approach saves the event handlers from the trouble of dealing with the OpenFlow protocol.
|
Thanks for working on this! I'm very busy at the moment, but will do a review when I have a chance (hopefully less than a week). I think I might suggest some minor tweaks, but I definitely think it should be merged. I am actually hoping to roll dart over to release very soon, though, so I think this will maybe get pushed to the new dev branch. (I'm hesitant to make behavioral changes so close to rolling the branches over.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to address a TODO item found in arp_helper.
Details are in the commit logs, but the functionality is not preserved 100%: