Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multipass properties #890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hardikcc
Copy link

Hi,

I have additional properties to multipass request. New properties are:

tag_string
identifier,
remote_ip,
return_to

I have also fixed the test to utilize the MultipassSecret instead of ShopifyToken.

Please merge.

@nozzlegear
Copy link
Owner

Hey @hardikcc thanks for the pull request! Just to clarify, are these new properties required for using MultipassService.GetMultipassUrl, i.e. the call to Shopify would fail without them? If they're not required I'd like to add an overload instead that will accept the previous Customer class and a new one that will accept the MultipassRequest class.

@hardikcc
Copy link
Author

Hello @nozzlegear, these are optional parameters. GetMultipassUrl will definitely work without them. Let me make these changes.

@nozzlegear
Copy link
Owner

@hardikcc Awesome, thanks! Let me know when you've got them ready and I'll get it merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants