-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update .golangci.yml #49
Conversation
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
.golangci.yml
Outdated
@@ -103,7 +102,6 @@ linters: | |||
- makezero | |||
- misspell | |||
- nakedret | |||
- nestif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave nestif
- it is a good practice to avoid deep nesting
Signed-off-by: adisos <[email protected]>
/* | ||
Copyright 2023- IBM Inc. All Rights Reserved. | ||
SPDX-License-Identifier: Apache-2.0 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the start year needs to be changed (2023). There's no need for longer comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preferred to use the same header style as in the other repos, so it is more consistent.
No description provided.