icmp followup: separate types for ICMP with 8-bit type/code, and with… #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Also, rename NewMap to NewHashMap Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Co-authored-by: Adi Sosnovich <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
interval: * Separate tests from interval_test.go * Improve documentation. * Export and set-like functions that are well defined. * Rename interval.Subtract to interval.SubtractSplit, and add tests. * Handle empty cases first. * Preallocate Elements. intervalset: * Guard Size() from overflow, and use intervalset.CalculateSize(). * Handle empty cases first. * Remove String() method, since it is not obvious; clients should implement. Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
… RFC-only combinations Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… RFC-only combinations