icmp followup: separate types for ICMP with 8-bit type/code, and with… #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RFC-only combinations Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
Signed-off-by: adisos <[email protected]>
zivnevo
requested changes
Oct 1, 2024
pkg/netset/icmpset.go
Outdated
| } | ||
|
|
||
| func (s *ICMPSet) Contains(i int) bool { | ||
| return ((1 << i) & (*s)) != 0 | ||
| // pathLeft creates a new TCPUDPSet, implemented using LeftTriple. |
pkg/netset/icmpset.go
Outdated
| tc := cube.ICMPTypeCode() | ||
| if tc == nil { | ||
| return "" | ||
| func gettICMPCubeStr(cube ds.Pair[*TypeSet, *CodeSet]) string { |
There was a problem hiding this comment.
Suggested change
| func gettICMPCubeStr(cube ds.Pair[*TypeSet, *CodeSet]) string { | |
| func getICMPCubeStr(cube ds.Pair[*TypeSet, *CodeSet]) string { |
Signed-off-by: adisos <[email protected]>
zivnevo
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… RFC-only combinations
issue #68 (new ICMP type not restricted only to RFC type,code combinations).