Skip to content

Commit

Permalink
cmd package test improvements (#258)
Browse files Browse the repository at this point in the history
* cmd package test improvements

* tiny fix

* comment-out a test with json format since its output file cause other tests in connlist_test to fail

* merge with master

* remove dups

* handling case of json output which can not be saved under its test dir

* adding cli test `command_test` to the make test-update

* running make test-update after merge

* code updates

* generating new output files by running make test-update

* remove old output files

* remove cli output dir (not needed anymore)

* fixes

* Update pkg/internal/testutils/testutils.go

Co-authored-by: Adi Sosnovich <[email protected]>

* fixes

* fix lint err

* fix

* merge master

* empty format handle

* fixing diff testName issue

* moving output to a new dir

* pkges depth and get tests dir

---------

Co-authored-by: Adi Sosnovich <[email protected]>
  • Loading branch information
shireenf-ibm and adisos authored Dec 7, 2023
1 parent 0cd241b commit e86bf5a
Show file tree
Hide file tree
Showing 206 changed files with 658 additions and 717 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ test:
test-update: # overrides/ generates tests' expected output files for relevant tests
# if the format is dot - generates also png files
@echo -- $@ --
go test ./pkg/netpol/connlist/ ./pkg/netpol/diff/ --args --update
go test ./pkg/netpol/connlist/ ./pkg/netpol/diff/ ./pkg/cli --args --update
Loading

0 comments on commit e86bf5a

Please sign in to comment.