Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff dot output enhancements #246

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Conversation

shireenf-ibm
Copy link
Contributor

@shireenf-ibm shireenf-ibm linked an issue Oct 2, 2023 that may be closed by this pull request
2 tasks
@shireenf-ibm
Copy link
Contributor Author

This is the const legend section which is added to all dot graphs :

nodesep=0.5
subgraph cluster_legend {
  label="Legend"
  fontsize = 10
  margin=0
  a [style=invis height=0 width=0]
  b [style=invis height=0 width=0]
  c [style=invis height=0 width=0]
  d [style=invis height=0 width=0]
  e [style=invis height=0 width=0]
  f [style=invis height=0 width=0]
  g [style=invis height=0 width=0]
  h [style=invis height=0 width=0]
  {rank=source a b c d}
  {rank=same e f g h}
  a -> b [label="added connection", color="#008000" fontcolor="#008000" fontsize = 10 arrowsize=0.2]
  c -> d [label="removed connection", color="red2" fontcolor="red2" fontsize = 10 arrowsize=0.2]
  e -> f [label="changed connection", color="magenta" fontcolor="magenta" fontsize = 10 arrowsize=0.2]
  g -> h [label="non-changed connection", color="grey" fontcolor="grey" fontsize = 10 arrowsize=0.2]
  np [label="new peer" color="#008000" fontcolor="#008000" fontsize = 10]
  lp [label="lost peer" color="red" fontcolor="red" fontsize = 10]
  pp [label="persistent peer" color="blue" fontcolor="blue" fontsize = 10]
  {rank=sink np lp pp}
  np->lp [style=invis]
  lp->pp [style=invis]
}

In code wrote it using some const variables and funcs to avoid lint errors and for easy changes to be made if needed in future

@shireenf-ibm shireenf-ibm requested a review from adisos October 2, 2023 08:19
Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Added a few comments.

docs/diff_output.md Show resolved Hide resolved
docs/diff_output.md Outdated Show resolved Hide resolved
docs/diff_output.md Outdated Show resolved Hide resolved
docs/diff_output.md Outdated Show resolved Hide resolved
@shireenf-ibm shireenf-ibm requested a review from adisos October 3, 2023 07:57
docs/diff_output.md Outdated Show resolved Hide resolved
Co-authored-by: Adi Sosnovich <[email protected]>
@shireenf-ibm shireenf-ibm requested a review from adisos October 3, 2023 09:03
@shireenf-ibm shireenf-ibm merged commit 6226653 into main Oct 3, 2023
4 checks passed
@shireenf-ibm shireenf-ibm deleted the diff_dot_view_enhancement branch October 3, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dot outputs of diff command - enhancements
2 participants