Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using cli runtime builder #261

Merged
merged 15 commits into from
Nov 8, 2023
Merged

using cli runtime builder #261

merged 15 commits into from
Nov 8, 2023

Conversation

adisos
Copy link
Collaborator

@adisos adisos commented Nov 2, 2023 •
edited
Loading

issue #263

@adisos
wip1
b80eaec 
Signed-off-by: adisos <[email protected]>
@adisos adisos marked this pull request as draft November 2, 2023 09:27
adisos added 11 commits November 2, 2023 15:16
@adisos
updates + fix lint issue
0851656 
Signed-off-by: adisos <[email protected]>
@adisos
additional linter fixes
8a86ec0 
Signed-off-by: adisos <[email protected]>
@adisos
updtes
e224609 
Signed-off-by: adisos <[email protected]>
@adisos
additional updates
28df522 
Signed-off-by: adisos <[email protected]>
@adisos
updates
fff2a7b 
Signed-off-by: adisos <[email protected]>
@adisos
fix lint issues
338e5fb 
Signed-off-by: adisos <[email protected]>
@adisos
update
1e720fe 
Signed-off-by: adisos <[email protected]>
@adisos
updates
14a71a5 
Signed-off-by: adisos <[email protected]>
@adisos
updates
a00d9ed 
Signed-off-by: adisos <[email protected]>
@adisos
updates
f8c0d0e 
Signed-off-by: adisos <[email protected]>
@adisos
updates
daeb48f 
Signed-off-by: adisos <[email protected]>
@adisos adisos marked this pull request as ready for review November 6, 2023 20:40
@adisos adisos linked an issue Nov 6, 2023 that may be closed by this pull request
Resources scan refactoring #263
Closed
@adisos adisos requested a review from zivnevo November 6, 2023 20:45
zivnevo
zivnevo requested changes Nov 8, 2023
View reviewed changes
pkg/netpol/manifests/fsscanner/manifests_test.go Outdated Show resolved Hide resolved
pkg/netpol/manifests/fsscanner/manifests_test.go Outdated Show resolved Hide resolved
pkg/netpol/manifests/parser/k8sobj.go Outdated Show resolved Hide resolved
pkg/netpol/manifests/parser/parser.go Outdated Show resolved Hide resolved
pkg/netpol/manifests/parser/parser.go Outdated Show resolved Hide resolved
pkg/netpol/eval/eval_test.go Outdated Show resolved Hide resolved
cmd/netpolicy/cmd/evaluate.go Show resolved Hide resolved
pkg/netpol/diff/connectivity_diff.go Show resolved Hide resolved
zivnevo
zivnevo reviewed Nov 8, 2023
View reviewed changes
cmd/netpolicy/cmd/evaluate.go Outdated Show resolved Hide resolved
pkg/netpol/diff/connectivity_diff.go Outdated Show resolved Hide resolved
pkg/netpol/diff/diff.go Outdated Show resolved Hide resolved
pkg/netpol/diff/diff.go Outdated Show resolved Hide resolved
pkg/netpol/diff/connectivity_diff.go Show resolved Hide resolved
zivnevo
zivnevo previously approved these changes Nov 8, 2023
View reviewed changes
pkg/netpol/diff/diff.go Show resolved Hide resolved
pkg/netpol/diff/diff_errors.go Outdated Show resolved Hide resolved
@adisos
remove comment
dbd8905 
Signed-off-by: adisos <[email protected]>
@adisos adisos mentioned this pull request Nov 8, 2023
Closed
zivnevo
zivnevo approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@zivnevo zivnevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if in pkg/netpol/diff we should rename dir1 and dir2 to something like v1 and v2, or maybe go back to old and new?

@adisos
Copy link
Collaborator Author

adisos commented Nov 8, 2023

I wonder if in pkg/netpol/diff we should rename dir1 and dir2 to something like v1 and v2, or maybe go back to old and new?

Currently the cli args and outputs are consistent with dir1 and dir2, though we can change of course.. should open a separate issue?

@adisos adisos merged commit 252d38a into main Nov 8, 2023
@adisos adisos deleted the using-cli-runtime-builder branch November 8, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivnevo zivnevo zivnevo approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resources scan refactoring
2 participants
@adisos @zivnevo